Skip to content

PARQUET-2121: Remove descriptions for the removed modules #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shangxinli merged 2 commits into from
Mar 4, 2022
Merged

PARQUET-2121: Remove descriptions for the removed modules #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1082d3c
PARQUET-2121: Remove descriptions for the removed modules
sekikn Feb 13, 2022
ac83111
Add '(deprecated)' to removed modules in README.md instead of removin…
sekikn Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target
*.orig
*.rej
dependency-reduced-pom.xml
parquet-scrooge/.cache
.idea/*
target/
.cache
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ Parquet is a very active project, and new features are being added quickly. Here
* Type-specific encoding
* Hive integration (deprecated)
* Pig integration
* Cascading integration
Copy link
Contributor

@shangxinli shangxinli Feb 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the code is still there, do you think we can just add '(deprecated)' here?

Copy link
Contributor Author

@sekikn sekikn Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment, @shangxinli! I updated the PR.
Instead of removing the lines, I just added '(deprecated)' to parquet-cascading* and parquet-scrooge in README.md, just like parquet-hive.

* Cascading integration (deprecated)
* Crunch integration
* Apache Arrow integration
* Apache Scrooge integration
* Scrooge integration (deprecated)
* Impala integration (non-nested)
* Java Map/Reduce API
* Native Avro support
Expand All @@ -92,7 +92,7 @@ Note that to use an Input or Output format, you need to implement a WriteSupport
We've implemented this for 2 popular data formats to provide a clean migration path as well:

### Thrift
Thrift integration is provided by the [parquet-thrift](https://github.com/apache/parquet-mr/tree/master/parquet-thrift) sub-project. If you are using Thrift through Scala, you may be using Twitter's [Scrooge](https://github.com/twitter/scrooge). If that's the case, not to worry -- we took care of the Scrooge/Apache Thrift glue for you in the [parquet-scrooge](https://github.com/apache/parquet-mr/tree/master/parquet-scrooge) sub-project.
Thrift integration is provided by the [parquet-thrift](https://github.com/apache/parquet-mr/tree/master/parquet-thrift) sub-project.

### Avro
Avro conversion is implemented via the [parquet-avro](https://github.com/apache/parquet-mr/tree/master/parquet-avro) sub-project.
Expand Down
9 changes: 3 additions & 6 deletions parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftReadSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ public class ThriftReadSupport<T> extends ReadSupport<T> {
/**
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified using this key
* (for example, ScroogeRecordConverter from parquet-scrooge).
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified using this key.
*/
private static final String RECORD_CONVERTER_CLASS_KEY = "parquet.thrift.converter.class";

Expand All @@ -77,8 +76,7 @@ public class ThriftReadSupport<T> extends ReadSupport<T> {
/**
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified
* (for example, ScroogeRecordConverter from parquet-scrooge).
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified.
*
* @param conf a mapred jobconf
* @param klass a thrift class
Expand All @@ -93,8 +91,7 @@ public static void setRecordConverterClass(JobConf conf,
/**
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified
* (for example, ScroogeRecordConverter from parquet-scrooge).
* as <a href="http://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified.
*
* @param conf a configuration
* @param klass a thrift class
Expand Down
163 changes: 0 additions & 163 deletions parquet_cascading.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@
<japicmp.version>0.14.2</japicmp.version>
<shade.prefix>shaded.parquet</shade.prefix>
<hadoop.version>2.10.1</hadoop.version>
<cascading.version>2.7.1</cascading.version>
<cascading3.version>3.1.2</cascading3.version>
<parquet.format.version>2.9.0</parquet.format.version>
<previous.version>1.12.0</previous.version>
<thrift.executable>thrift</thrift.executable>
Expand Down Expand Up @@ -461,7 +459,6 @@
<exclude>**/*.parquet</exclude>
<exclude>**/*.avro</exclude>
<exclude>**/*.json</exclude>
<exclude>**/names.txt</exclude> <!-- parquet-cascading test data -->
<exclude>**/*.avsc</exclude>
<exclude>**/*.iml</exclude>
<exclude>**/*.log</exclude>
Expand Down