Skip to content

Add primitive_null metadata for example Variant values#84

Merged
mapleFU merged 3 commits intoapache:masterfrom
alamb:alamb/fix_variant_null
May 23, 2025
Merged

Add primitive_null metadata for example Variant values#84
mapleFU merged 3 commits intoapache:masterfrom
alamb:alamb/fix_variant_null

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented May 21, 2025

As @mapleFU points out, the metadata for the primitive null variant is missing. Let's add it with an explanation of where it came from

@alamb alamb changed the title Add primitive_null metadata Add primitive_null metadata for example Variant values May 21, 2025
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @alamb

Comment thread variant/README.md Outdated
Co-authored-by: Fokko Driesprong <fokko@apache.org>
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented May 21, 2025

Thanks for the quick review @Fokko 🙏

Comment thread variant/README.md Outdated
@mapleFU mapleFU merged commit e7b28dd into apache:master May 23, 2025
@alamb alamb deleted the alamb/fix_variant_null branch May 23, 2025 18:20
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented May 23, 2025

Thanks again @mapleFU and @Fokko

@alamb alamb mentioned this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential issues with Null variant example

3 participants