Merge alternate OpenType Advanced Typographic Table (ATT) support. #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Please ignore. |
Contributor
|
Is this some work in progress? |
Member
Author
|
Sorry, created PR against wrong branch. It was intended for non-apache fork only, skynav/pdfbox. |
Contributor
|
Hmm, it's a pity. Looks interesting. Is there chance to merge it into pdfbox sometime in the future? |
Member
Author
|
Yes, it is possible. There is some overlap with the limited ATT support that has already been added to fontbox, i.e., GlyphSubsitutionTable, so that would have to be worked out. My implementation is already being used in https://github.com/apache/xmlgraphics-fop/tree/trunk/fop-core/src/main/java/org/apache/fop/complexscripts and in https://github.com/skynav/ttt/tree/master/ttt-ttpe. |
Contributor
|
Cool, good to know. I put this on my TODO list. Thanks! |
danfickle
added a commit
to danfickle/pdfbox
that referenced
this pull request
Oct 13, 2021
Started with work by Glenn Adams (all bugs are mine): apache#126 Trying to modernize to Java 8 by adding generics, etc. Also early work in integrating with PDAbstractContentStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.