use Java CompletionStage instead of Scala Future in pekko-persistence Java APIs#2092
use Java CompletionStage instead of Scala Future in pekko-persistence Java APIs#2092pjfanning merged 14 commits intoapache:mainfrom
Conversation
Sketching out apache#1417 - incomplete and notably not bothering with binary compatibility yet, just to illustrate the idea.
| persistenceId: String, | ||
| criteria: SnapshotSelectionCriteria): Future[Option[SelectedSnapshot]] = | ||
| doLoadAsync(persistenceId, criteria).map(option) | ||
| doLoadAsync(persistenceId, criteria).asScala.map(option) |
There was a problem hiding this comment.
map(option)(org.apache.pekko.dispatch.ExecutionContexts.parasitic)
53f8c69 to
176fa91
Compare
|
@pjfanning Regarding Context switch is fine (and needed) for long running async operations, but those are typically composed with |
|
@He-Pin I made a couple of changes after your review was made including fixing an issue. Do you still think it is ok to merge as is? |
Uh oh!
There was an error while loading. Please reload this page.