Skip to content

[Do not merge] This is just a fake PR to run the tests#10857

Closed
gortiz wants to merge 74 commits intoapache:masterfrom
gortiz:always-unsafe-buffers
Closed

[Do not merge] This is just a fake PR to run the tests#10857
gortiz wants to merge 74 commits intoapache:masterfrom
gortiz:always-unsafe-buffers

Conversation

@gortiz
Copy link
Copy Markdown
Contributor

@gortiz gortiz commented Jun 6, 2023

This is a test for #10528. The code is the same, but it always uses the unsafe buffer library

@gortiz gortiz marked this pull request as draft June 6, 2023 17:09
@gortiz gortiz force-pushed the always-unsafe-buffers branch from ec59b45 to c0c3463 Compare June 6, 2023 17:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2023

Codecov Report

❌ Patch coverage is 0% with 491 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.11%. Comparing base (3b2e31c) to head (59df06f).
⚠️ Report is 4811 commits behind head on master.

Files with missing lines Patch % Lines
...he/pinot/segment/spi/memory/unsafe/MmapMemory.java 0.00% 131 Missing ⚠️
...ache/pinot/segment/spi/memory/PinotDataBuffer.java 0.00% 110 Missing ⚠️
...t/segment/spi/memory/NonNativePinotDataBuffer.java 0.00% 70 Missing ⚠️
...t/segment/spi/memory/unsafe/UnsafePinotBuffer.java 0.00% 62 Missing ⚠️
...pache/pinot/segment/spi/memory/ByteBufferUtil.java 0.00% 40 Missing ⚠️
.../pinot/segment/spi/memory/unsafe/DirectMemory.java 0.00% 22 Missing ⚠️
...pi/memory/SmallWithFallbackPinotBufferFactory.java 0.00% 13 Missing ⚠️
...nt/spi/memory/unsafe/UnsafePinotBufferFactory.java 0.00% 12 Missing ⚠️
...pache/pinot/segment/spi/memory/unsafe/Unsafer.java 0.00% 9 Missing ⚠️
...gment/spi/memory/ByteBufferPinotBufferFactory.java 0.00% 7 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (3b2e31c) and HEAD (59df06f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (3b2e31c) HEAD (59df06f)
unittests2 1 0
integration1 1 0
integration2 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #10857       +/-   ##
=============================================
- Coverage     34.52%    0.11%   -34.41%     
=============================================
  Files          2174     2186       +12     
  Lines        116848   117315      +467     
  Branches      17692    17722       +30     
=============================================
- Hits          40339      137    -40202     
- Misses        72991   117158    +44167     
+ Partials       3518       20     -3498     
Flag Coverage Δ
integration1 ?
integration1temurin20 0.00% <0.00%> (?)
integration2 ?
integration2temurin11 0.00% <0.00%> (?)
integration2temurin17 0.00% <0.00%> (?)
integration2temurin20 0.00% <0.00%> (?)
unittests1temurin11 0.00% <0.00%> (?)
unittests2 ?
unittests2temurin11 0.11% <0.00%> (?)
unittests2temurin17 0.11% <0.00%> (?)
unittests2temurin20 0.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gortiz gortiz force-pushed the always-unsafe-buffers branch from c0c3463 to 121be3e Compare June 6, 2023 19:13
gortiz added 26 commits June 6, 2023 12:29
Spotless doesn't like the suppression comments
Now that pinot-segment-spi uses sun.misc.unsafe, in order to compile with JDK 11 and --release 8 we would need to supply --bootstrap <path to JDK 8>
gortiz added 27 commits June 6, 2023 12:29
…tless.

These checks are already executed by the linter job
While -DskipTests skips the test execution, -Dmaven.test.skip=true also skips the compilation. This is necessary in cases where we use libraries that only work in Java > 11. Alternativelly we could use profiles to change the dependencies, but that would make the compilation process more complex
@gortiz gortiz force-pushed the always-unsafe-buffers branch from 121be3e to 59df06f Compare June 6, 2023 19:30
@gortiz gortiz closed this Jun 7, 2023
@gortiz gortiz deleted the always-unsafe-buffers branch June 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants