Skip to content

[draft] Run tests with Corretto 21#11657

Closed
gortiz wants to merge 1 commit intoapache:masterfrom
gortiz:java-21-tests
Closed

[draft] Run tests with Corretto 21#11657
gortiz wants to merge 1 commit intoapache:masterfrom
gortiz:java-21-tests

Conversation

@gortiz
Copy link
Copy Markdown
Contributor

@gortiz gortiz commented Sep 22, 2023

This PR tries to run Pinot tests with Java 21 while compiling with Java 11. The reason to do not compile with Java 21 is explained in #11656

@gortiz gortiz marked this pull request as draft September 22, 2023 10:24
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 22, 2023

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (3501b86) to head (40ab653).
⚠️ Report is 4333 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pinot/segment/spi/memory/PinotDataBuffer.java 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3501b86) and HEAD (40ab653). Click for more details.

HEAD has 46 uploads less than BASE
Flag BASE (3501b86) HEAD (40ab653)
unittests 6 0
unittests2 3 0
temurin 12 0
java-17 4 0
java-11 4 0
integration 6 2
integration2 3 0
java-20 4 0
integration1 3 0
unittests1 3 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #11657       +/-   ##
=============================================
- Coverage     63.06%    0.00%   -63.07%     
=============================================
  Files          2342     2342               
  Lines        125690   125692        +2     
  Branches      19306    19309        +3     
=============================================
- Hits          79262        0    -79262     
- Misses        40778   125692    +84914     
+ Partials       5650        0     -5650     
Flag Coverage Δ
corretto 0.00% <0.00%> (?)
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 ?
java-11 ?
java-17 ?
java-20 ?
java-21 0.00% <0.00%> (?)
temurin ?
unittests ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0
Copy link
Copy Markdown
Contributor

shall we use openjdk 21 or corretto?

@gortiz
Copy link
Copy Markdown
Contributor Author

gortiz commented Sep 25, 2023

shall we use openjdk 21 or corretto?

If there is a serious alternative to openjdk docker images, we should always use the alternative. The reason is explained in the deprecation note of https://hub.docker.com/_/openjdk. Openjdk is not production ready. It is the image that is created from the master branch of openjdk repo. That means that openjdk will only create images for the first 6 months for each version, even LTS. For example, Java 21 images won't be created once Java 22 is released.

That is why we choose to use either Temurin (old adoptjdk), Microsoft or Corretto. As of today, only Corretto provides a Java 21 image, so that is the one I've chosen here. We can change to Temurin once it is released in order to have an homogeneous pipeline.

@gortiz
Copy link
Copy Markdown
Contributor Author

gortiz commented Sep 25, 2023

It seems there are some issues with this PR. I've tried a different (and probably better) approach in #11672.

While this PR (#11657) changes the pipeline to compile with Java 11 and run tests with Java 21, #11672 actually compiles with Java 21 and tries to fix the issues we have (or disable in Java 21 the ones that cannot be fixed as today, like spotless). Therefore it seems that #11672 is better as it is less hacky and closer to the actual pipeline we would like to have once Java 21 is fully supported.

@gortiz gortiz closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants