Move scala dependencies to root pom#11671
Merged
xiangfu0 merged 3 commits intoapache:masterfrom Oct 4, 2023
Merged
Conversation
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11671 +/- ##
============================================
+ Coverage 62.95% 63.10% +0.14%
- Complexity 1114 1118 +4
============================================
Files 2342 2342
Lines 125919 125919
Branches 19362 19362
============================================
+ Hits 79278 79461 +183
+ Misses 40979 40805 -174
+ Partials 5662 5653 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Sep 25, 2023
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
LGTM! @xiangfu0 can you also take a look?
xiangfu0
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason to be of this PR is to be able to progress on #11656.
As explained there, the scala version currently used in Pinot does not support Java 21. This PR changes the code to:
2.12.11to2.12.18.scala.versionhomogeneous. Previously different projects mixed the meaning ofscala.versionandscala.compat.version. Nowscala.versionis always the actual scala version used (with minor included) andscala.compat.versionis the scala family used (2.12 by default and 2.13 if some profile is enabled).This changes are included in #11672, so we can decide to merge this alone or merge everything together.