Add "Good Practices" section in the contributing guide#884
Merged
jbonofre merged 6 commits intoapache:mainfrom Jan 30, 2025
Merged
Add "Good Practices" section in the contributing guide#884jbonofre merged 6 commits intoapache:mainfrom
jbonofre merged 6 commits intoapache:mainfrom
Conversation
jbonofre
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
snazy,
takidau and
vvcephei
as code owners
snazy
reviewed
Jan 27, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Overall LGTM. Added some wording suggestions.
Co-authored-by: Robert Stupp <snazy@snazy.de>
Co-authored-by: Robert Stupp <snazy@snazy.de>
Co-authored-by: Robert Stupp <snazy@snazy.de>
Co-authored-by: Robert Stupp <snazy@snazy.de>
Member
Author
|
I committed @snazy suggestions. Thanks ! |
dimas-b
approved these changes
Jan 27, 2025
snazy
reviewed
Jan 27, 2025
Co-authored-by: Robert Stupp <snazy@snazy.de>
snazy
approved these changes
Jan 28, 2025
dimas-b
approved these changes
Jan 28, 2025
This was referenced Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, this PR adds a "good practices" section in the contributing guide.