Spec: Fix incorrect reference to IcebergErrorResponse in notifications-api.yaml#957
Merged
flyrain merged 4 commits intoapache:mainfrom Feb 6, 2025
Merged
Conversation
…+ Iceberg API YAML (apache#935)" This reverts commit 3685065.
HonahX
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
flyrain
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
notification-api.yaml, the current reference ofIcebergErrorResponseis pointing to the wrong model. We should use the one defined incomponents/schemasinstead ofcomponents/responsesif we want to customize the example of the corresponding error code.The incorrect reference cause a problematic
responses-IcebergErrorResponsemodel be generated in thebundled-polaris-catalog-service.yaml, which cause an error in swagger editor.