Remove 'binary' buffer usage in Node

[nolanlawson]

We use this in both our tests and in the running code. Per the docs:

'binary' - A way of encoding raw binary data into strings by using only the first 8 bits of each character. This encoding method is deprecated and should be avoided in favor of Buffer objects where possible. This encoding will be removed in future versions of Node.

[daleharvey]

Got a pointer to where we are doing it incorrectly?

[nolanlawson]

Everywhere where we are calling new buffer(someData, 'binary') (too many to list; there are plenty). Supposedly it's deprecated, although it still works in iojs and Node 0.12, so I don't know how important this issue really is.

[calvinmetcalf]

they key is you should be specific about how you want the string to be
decoded, likely it's utf8

On Thu, Aug 6, 2015 at 10:12 AM Nolan Lawson notifications@github.com
wrote:

Everywhere where we are calling new buffer(someData, 'binary') (too many
to list; there are plenty). Supposedly it's deprecated, although it still
works in iojs and Node 0.12, so I don't know how important this issue
really is.

—
Reply to this email directly or view it on GitHub
#2580 (comment).

[daleharvey]

No longer deprecated - nodejs/node#3441