Skip to content

Fix MessageId::getDataAsString() crashed with MSVC debug config #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 1 commit into from
Nov 9, 2022
Merged

Fix MessageId::getDataAsString() crashed with MSVC debug config #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions include/pulsar/Message.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,15 @@ class PULSAR_PUBLIC Message {
* Get string representation of the message
*
* @return the string representation of the message payload
*
* NOTE: For MSVC with debug mode, return a thread local std::string object to avoid memory allocation
* across DLLs and applications, which could lead to a crash.
*/
#if defined(_MSC_VER) && !defined(NDEBUG)
const std::string& getDataAsString() const;
#else
std::string getDataAsString() const;
#endif

/**
* Get key value message.
Expand Down
8 changes: 8 additions & 0 deletions lib/Message.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,15 @@ const void* Message::getData() const { return impl_->payload.data(); }

std::size_t Message::getLength() const { return impl_->payload.readableBytes(); }

#if defined(_MSC_VER) && !defined(NDEBUG)
const std::string& Message::getDataAsString() const {
thread_local std::string value;
value = std::string{static_cast<const char*>(getData()), getLength()};
return value;
}
#else
std::string Message::getDataAsString() const { return std::string((const char*)getData(), getLength()); }
#endif

Message::Message() : impl_() {}

Expand Down