Skip to content

Conversation

@shibd
Copy link
Member

@shibd shibd commented Nov 11, 2022

Motivation

There is a problem with the getLastMessageId method currently implemented.

It is recursively invoking itself.

void Consumer::getLastMessageIdAsync(GetLastMessageIdCallback callback) {
if (!impl_) {
callback(ResultConsumerNotInitialized, MessageId());
return;
}
getLastMessageIdAsync([callback](Result result, const GetLastMessageIdResponse& response) {
callback(result, response.getLastMessageId());
});
}

Modifications

  • Let it call the actual implementation.

Note: MultiTopicConsumer.getLastMessageId() is not supported for the time being. I will support it later. Supporting MultiTopicConsumer requires the implementation of MultiMessageId, which requires more thought and design.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@BewareMyPower BewareMyPower added bug Something isn't working release/3.0 labels Nov 11, 2022
@BewareMyPower BewareMyPower merged commit de94bc5 into apache:main Nov 17, 2022
@RobertIndie RobertIndie added this to the 3.1.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants