Fix getLastMessageId method dead recursion. #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a problem with the
getLastMessageIdmethod currently implemented.It is recursively invoking itself.
pulsar-client-cpp/lib/Consumer.cc
Lines 293 to 301 in ad79bec
Modifications
Note:
MultiTopicConsumer.getLastMessageId()is not supported for the time being. I will support it later. SupportingMultiTopicConsumerrequires the implementation of MultiMessageId, which requires more thought and design.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)