[improve] Exclude debug artifact in the release and tar the windows artifacts #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows artifacts Motivation The debug artifact for the windows system is too large. They are only used for debugging and doesn't need to include in the release. And it's better to zip tar the `windows-static` artifact to make it easier to download through the command line. The final result looks like this: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.1.0-candidate-1/ Modification * Skip include the windows debug artifact in the release * Tar `windows-static` artifact in the release.
Contributor
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
Could you add a release process so that it would be more clear that when would these scripts be used?
BewareMyPower
approved these changes
Nov 24, 2022
RobertIndie
added a commit
that referenced
this pull request
Dec 1, 2022
…ows artifacts (#124) Motivation The debug artifact for the windows system is too large. They are only used for debugging and doesn't need to include in the release. And it's better to zip tar the `windows-static` artifact to make it easier to download through the command line. The final result looks like this: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.1.0-candidate-1/ Modification * Skip include the windows debug artifact in the release * Tar `windows-static` artifact in the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The debug artifact for the windows system is too large. They are only used for debugging and don't need to include in the release. And it's better to tar the
windows-staticartifact to make it easier to download.The final result looks like this: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.1.0-candidate-1/
Modifications
windows-staticartifacts in the release.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)