[feat] Support acknowledging a list of messages #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
shibd
force-pushed
the
ack_message_list
branch
4 times, most recently
from
d274f0b to
5013c9f
Compare
Member
Author
BewareMyPower
requested changes
Nov 1, 2022
BewareMyPower
requested changes
Nov 1, 2022
Contributor
|
Overall LGTM except the comments I've mentioned. |
shibd
force-pushed
the
ack_message_list
branch
from
1bc3eba to
ff4dcb2
Compare
BewareMyPower
approved these changes
Nov 1, 2022
BewareMyPower
referenced
this pull request
in BewareMyPower/pulsar-client-cpp
Nov 29, 2022
…meMs is 0 ### Motivation When `ackGroupingTimeMs` is 0, `AckGroupingTrackerDisabled` will be created to acknowledge messages immediately. However, since the `addAcknowledgeList` method is not implemented in #23, it doesn't work. ### Modifications Implement `AckGroupingTrackerDisabled::addAcknowledgeList`. Move the protocol version validation from `AckGroupingTrackerEnabled` to the base class `AckGroupingTracker` so that the `doImmediateAck` overload that accepts `std::set<MessageId>` can be reused. Add testing params to `testAckMsgList` and `testAckMsgListWithMultiConsumer` so that various `ackGroupingTimeMs` can be verified.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#90
Modifications
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
shibd#3