[Tests] Unregister JettyStatisticsCollector to fix memory leak in Broker shutdown #10192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down - Unregister JettyStatisticsCollector from Prometheus client's default Collector registry at shutdown - Clear metricsServlet reference at shutdown of PulsarService
lhotari
changed the title
merlimat
approved these changes
Apr 12, 2021
315157973
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's a memory leak in tests via Prometheus client default CollectorRegistry. This has an impact in tests when a lot of Pulsar broker instances are created during tests.
Modifications
Unregister JettyStatisticsCollector from Prometheus client's default
Collector registry at shutdown
Clear metricsServlet reference at shutdown of PulsarService