Skip to content

[Build] Fix warning about parent.relativePath in buildtools/pom.xml #10194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eolivelli merged 1 commit into from
Apr 13, 2021
Merged

[Build] Fix warning about parent.relativePath in buildtools/pom.xml #10194

eolivelli merged 1 commit into from
Apr 13, 2021

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Apr 12, 2021 •
edited
Loading

Motivation

The relativePath setting is invalid in buildtools/pom.xml.

Reproducing the issue:

$ cd buildtools
$ mvn verify
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.pulsar:buildtools:jar:2.8.0-SNAPSHOT
[WARNING] 'parent.relativePath' of POM org.apache.pulsar:buildtools:2.8.0-SNAPSHOT (/home/lari/workspace-pulsar/pulsar/buildtools/pom.xml) points at org.apache.pulsar:pulsar instead of org.apache:apache, please verify your project structure @ line 25, column 11
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
...

Modifications

Set relativePath to an empty string. This solution is also recommended in this StackOverflow answer: https://stackoverflow.com/a/6006098 .

@lhotari lhotari changed the title Fix warning about parent.relativePath in buildtools/pom.xml [Build] Fix warning about parent.relativePath in buildtools/pom.xml Apr 12, 2021
@lhotari lhotari mentioned this pull request Apr 12, 2021
Merged
@merlimat merlimat added this to the 2.8.0 milestone Apr 12, 2021
@lhotari
Copy link
Member Author

lhotari commented Apr 13, 2021

/pulsarbot run-failure-checks

@eolivelli eolivelli merged commit 36924cc into apache:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@lhotari lhotari

Labels

area/test

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lhotari @merlimat @eolivelli