[Tests] Cleanup PulsarClient instances #10197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Apr 12, 2021
lhotari
force-pushed
the
lh-cleanup-pulsarclient-instances
branch
2 times, most recently
from
d8a2c4e to
82c1bfc
Compare
sijie
approved these changes
Apr 13, 2021
lhotari
force-pushed
the
lh-cleanup-pulsarclient-instances
branch
2 times, most recently
from
a0969bb to
a4dbd3a
Compare
Member
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 15, 2021
Member
Author
|
/pulsarbot run-failure-checks |
lhotari
force-pushed
the
lh-cleanup-pulsarclient-instances
branch
from
a4dbd3a to
fbccc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar tests currently leak a lot of PulsarClient instances
Modifications
@Cleanupfor handling cleanup