Add preciseTopicPublishRateLimiterEnable to broker.conf #10216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
@sijie I checked now. It would be needed. I'll add it. There's a lot of other configuration parameters missing from standalone.conf . Would it be necessary to create a separate issue to sync all missing parameters? |
michaeljmarshall
approved these changes
Apr 14, 2021
eolivelli
approved these changes
Apr 14, 2021
codelipenghui
approved these changes
Apr 15, 2021
lhotari
force-pushed
the
lh-add-preciseTopicPublishRateLimiterEnable-to-broker.conf
branch
from
578ba2f to
ccd409b
Compare
Member
Author
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #7078 introduced preciseTopicPublishRateLimiterEnable setting, but this setting is missing from
broker.conf. The impact of this is that it is required to usePULSAR_PREFIX_preciseTopicPublishRateLimiterEnable: "true"invalues.yamlto enable the setting. It would be more consistent with other settings ifpreciseTopicPublishRateLimiterEnable: "true"could be used.Modifications
Add
preciseTopicPublishRateLimiterEnable=falsetobroker.conf.