[pulsar-broker] Fix: handle failed partitions topic creation #10374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
codelipenghui,
jiazhai,
merlimat,
nkurihar and
sijie
rdhabalia
force-pushed
the
part_create
branch
2 times, most recently
from
491af3f to
1ee8b4b
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jun 1, 2021
eolivelli
requested changes
Jun 1, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
overall LGTM
but we are breaking the Admin API.
we should not remove an existing method, but only add a new one
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
Show resolved
Hide resolved
rdhabalia
force-pushed
the
part_create
branch
from
1ee8b4b to
858465d
Compare
rdhabalia
force-pushed
the
part_create
branch
from
858465d to
028d54c
Compare
rdhabalia
force-pushed
the
part_create
branch
from
028d54c to
90b9452
Compare
eolivelli
pushed a commit
that referenced
this pull request
Oct 8, 2021
* [pulsar-broker] Fix: handle failed partitions topic creation * fix test
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…10374) * [pulsar-broker] Fix: handle failed partitions topic creation * fix test
1 task
2 tasks
AnonHxy
pushed a commit
that referenced
this pull request
Aug 28, 2022
…ception: subscription already exists for topic (#17251) ### Motivation #10374 wants to handle the existing subscriptions when updating partition with `force` command parameter. However, it could not update the partition metadata if the `Subscription already exists for topic` exception comes. Because it miss updating when handling such exception.
Pomelongan
pushed a commit
to Pomelongan/pulsar
that referenced
this pull request
Aug 28, 2022
…ception: subscription already exists for topic (apache#17251) ### Motivation apache#10374 wants to handle the existing subscriptions when updating partition with `force` command parameter. However, it could not update the partition metadata if the `Subscription already exists for topic` exception comes. Because it miss updating when handling such exception.
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Nov 30, 2022
…10374) * [pulsar-broker] Fix: handle failed partitions topic creation * fix test
Technoboy-
pushed a commit
that referenced
this pull request
Mar 6, 2023
…ception: subscription already exists for topic (#17251) ### Motivation #10374 wants to handle the existing subscriptions when updating partition with `force` command parameter. However, it could not update the partition metadata if the `Subscription already exists for topic` exception comes. Because it miss updating when handling such exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Incrementing partition for the topic requires creating new partitions with existing subscriptions. Sometimes, partitions of the topic are distributed to multiple brokers, and the creation of few partitions may fail due to various reasons. However, retrying update-partition command for such topic fails with the below error
We frequently face this issue and need to manually update znode to fix the issue and increment partitions of the topic.
Modification
Handle
Subscription already exists for topicerror and create failed partitions to successfully increment partitions. Provideforceflag to handle the error and successfully create partially created partitons.