Implemented AtomicBoolean of havePendingRead in readMoreEntries() #10411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we're performing a compareAndSet type of operation in
readMoreEntries()in the persistent dispatchers on the fieldhavePendingRead, but the way we're doing it isn't thread-safe sincereadMoreEntries()isn't synchronized.As @rdhabalia mentioned in #9789 that there are no pending reads despite backlog and available permits, it seems like there may be a concurrency issue with the pending read status.
I need someone with more experience with concurrency primitives in Java to review this PR to indicate if it actually improves anything because I only found one place where there was a clear "compareAndSet" type of operation, so I don't see clearly competing accesses, and it's not clear to me if access on this field occurs from multiple threads in this location.