[#10503] allow user to set custom configs to plugin worker service #10504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sijie @merlimat @codelipenghui @nlu90 @tuteng @fantapsody please help to review this PR if you have time, thanks. |
5 tasks
sijie
approved these changes
May 8, 2021
tuteng
approved these changes
May 8, 2021
eolivelli
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10503
Motivation
#8560 provide an interface for functions worker service and allows user to implement their own functions worker as a plugin functions worker. It would be great if the user can pass some custom settings to plugin functions worker service through
WorkerConfig.Modifications
functionsWorkerServiceCustomConfigstoWorkerConfigVerifying this change