[fix #9640] remove pulsar-client-admin-api dependency : pulsar-client-original
#10563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ule for interface resolver
freeznet
force-pushed
the
freeznet/9640-remove-client-admin-api-dependency-pulsar-client-original
branch
from
3629c7a to
0557802
Compare
codelipenghui
approved these changes
May 13, 2021
Comment on lines
-150
to
-154
| /** | ||
| * @return the client Configuration Data that is being used | ||
| */ | ||
| ClientConfigurationData getClientConfigData(); | ||
|
|
Contributor
There was a problem hiding this comment.
We don't have a release that contains this API, it's ok here.
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
May 15, 2021
Member
|
@merlimat Can you review this? |
merlimat
approved these changes
May 17, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…ar-client-original` (apache#10563) * remove org.apache.pulsar.client.impl.conf.ClientConfigurationData * use MessageId instead of MessageIdImpl * get getClientConfigData back * fix io-kafka dependency * fix java-test-functions dependency * add pulsar-client-original to pulsar-functions-runtime-all * fix offload tests * fix import * change Gson to Jackson for OffloadProcessStatus * move OffloadProcessStatus as interface, add InterfaceDefaultMapperModule for interface resolver
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ar-client-original` (apache#10563) * remove org.apache.pulsar.client.impl.conf.ClientConfigurationData * use MessageId instead of MessageIdImpl * get getClientConfigData back * fix io-kafka dependency * fix java-test-functions dependency * add pulsar-client-original to pulsar-functions-runtime-all * fix offload tests * fix import * change Gson to Jackson for OffloadProcessStatus * move OffloadProcessStatus as interface, add InterfaceDefaultMapperModule for interface resolver
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9640
Part 1
Motivation
Module
pulsar-client-admin-apihas been introduced in #9246, but it pulling in many dependencies.Due to my mistaken ops on the git branch, the original PR #10513 has been closed, this PR will continue the work.
Modifications
remove
pulsar-client-originalfrompulsar-client-admin-api.Verifying this change