Skip to content

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 1, 2021

Motivation

#9640 Making the admin API POJOs into interfaces.

Resubmitting #10697 by @freeznet, just fixing conflicts with master here.

freeznet added 30 commits May 18, 2021 13:25
…remove-client-admin-api-dependency-pulsar-common

# Conflicts:
#	managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/PulsarAdminException.java
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ClusterData.java
…remove-client-admin-api-dependency-pulsar-common
…remove-client-admin-api-dependency-pulsar-common

# Conflicts:
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionCoordinatorStatus.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TransactionCoordinatorStats.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TransactionCoordinatorStatus.java
#	tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
@merlimat merlimat added this to the 2.8.0 milestone Jun 1, 2021
@merlimat merlimat force-pushed the 9640-remove-client-admin-api-dependency-pulsar-common branch from cee3d39 to 746d6fe Compare June 2, 2021 09:22
@merlimat merlimat merged commit 301a764 into apache:master Jun 2, 2021
@merlimat merlimat deleted the 9640-remove-client-admin-api-dependency-pulsar-common branch June 2, 2021 21:58
BewareMyPower added a commit to streamnative/kop that referenced this pull request Jun 8, 2021
### Motivation
apache/pulsar#10818 and apache/pulsar#10774 introduced API changes to `ClusterDataImpl` and `TenantInfoImpl`.

### Modifications
- Fix current code for new interface.
- Remove unused setup code.
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
* remove gson from admin api Topics.java

* Bookies.java

* Brokers.java

* BrokerStats.java

* fix PulsarAdminException

* Clusters.java

* Tenants.java

* minor fix on ResourceGroups

* Namespaces.java & OffloadPolicies

* temp remove JsonProperty in OffloadPolicies

* Topics & NonPersistentTopics

* ResourceQuotas with MixIn class

* Functions

* Sources.java

* Sinks.java

* Schemas.java

* resolve checkstyle

* minor fix

* Transactions.java

* fix stylecheck

* set ObjectMapper module

* fix ci

* fix PulsarAdminException

* remove gson

* remove swagger

* merge master

* remove swagger

* remove io.swagger

* remove commons-lang3

* use Objects.requireNonNull

* remove commons-lang3

* fix interface mapping

* fix ci

* extract OffloadPoliciesInterface

* extract FunctionStats interfaces

* fix unit test

* fix shaded class

* add object mapper mixin tests

* fix ci

* fix admin exception ci error

* UpdateOptions

* AutoFailoverPolicyData

* BrokerNamespaceIsolationData

* ClusterData

* FailureDomain

* FunctionInstanceStats

* NamespaceIsolationData

* OffloadPolicies

* TenantInfo

* FunctionStats

* fix stylecheck

* Fixed interface

* Fixed ClusterData equals method

* Fixed merge issue

* Fixed another merge issue

* Fixed test issue after merge

Co-authored-by: Rui Fu <freelz@gmail.com>
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
* remove gson from admin api Topics.java

* Bookies.java

* Brokers.java

* BrokerStats.java

* fix PulsarAdminException

* Clusters.java

* Tenants.java

* minor fix on ResourceGroups

* Namespaces.java & OffloadPolicies

* temp remove JsonProperty in OffloadPolicies

* Topics & NonPersistentTopics

* ResourceQuotas with MixIn class

* Functions

* Sources.java

* Sinks.java

* Schemas.java

* resolve checkstyle

* minor fix

* Transactions.java

* fix stylecheck

* set ObjectMapper module

* fix ci

* fix PulsarAdminException

* remove gson

* remove swagger

* merge master

* remove swagger

* remove io.swagger

* remove commons-lang3

* use Objects.requireNonNull

* remove commons-lang3

* fix interface mapping

* fix ci

* extract OffloadPoliciesInterface

* extract FunctionStats interfaces

* fix unit test

* fix shaded class

* add object mapper mixin tests

* fix ci

* fix admin exception ci error

* UpdateOptions

* AutoFailoverPolicyData

* BrokerNamespaceIsolationData

* ClusterData

* FailureDomain

* FunctionInstanceStats

* NamespaceIsolationData

* OffloadPolicies

* TenantInfo

* FunctionStats

* fix stylecheck

* Fixed interface

* Fixed ClusterData equals method

* Fixed merge issue

* Fixed another merge issue

* Fixed test issue after merge

Co-authored-by: Rui Fu <freelz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants