-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Revert "Enable pulsar function to send message to external pulsar clu… #10843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
codelipenghui
merged 2 commits into
apache:master
from
merlimat:revert-66231e313502bfe74fd28976560d4391c5cdefa5
Jun 7, 2021
Merged
Revert "Enable pulsar function to send message to external pulsar clu… #10843
codelipenghui
merged 2 commits into
apache:master
from
merlimat:revert-66231e313502bfe74fd28976560d4391c5cdefa5
Jun 7, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster (apache#8434)" This reverts commit 66231e3.
jerrypeng
approved these changes
Jun 6, 2021
eolivelli
approved these changes
Jun 6, 2021
codelipenghui
approved these changes
Jun 6, 2021
Contributor
|
hangc0276
approved these changes
Jun 7, 2021
…lve the failed tests
sijie
approved these changes
Jun 7, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
apache#10843) This reverts commit 66231e3. ### Motivation Reverting since the external cluster configuration was not not needed as there are better ways to interact with external pulsar clusters. A user can simply instantiate a Pulsar client, producer, or consumer in a function to interact with another pulsar cluster. This feature is also a security risk as it does not security handle authentication data and it will be written as plain text in the internal function's metadata topic.
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Aug 18, 2021
- this should have been part of apache#10843 which reverted apache#8434 changes
This was referenced Aug 18, 2021
1 task
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
apache#10843) This reverts commit 66231e3. ### Motivation Reverting since the external cluster configuration was not not needed as there are better ways to interact with external pulsar clusters. A user can simply instantiate a Pulsar client, producer, or consumer in a function to interact with another pulsar cluster. This feature is also a security risk as it does not security handle authentication data and it will be written as plain text in the internal function's metadata topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ster (#8434)"
This reverts commit 66231e3.
Motivation
Reverting since the external cluster configuration was not not needed as there are better ways to interact with external pulsar clusters. A user can simply instantiate a Pulsar client, producer, or consumer in a function to interact with another pulsar cluster. This feature is also a security risk as it does not security handle authentication data and it will be written as plain text in the internal function's metadata topic.