-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Revert "[Issue 8751] Update Dockerfile for Pulsar and Dashboard to Cr… #10861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate and Use pulsar User (nonroot user) (apache#8796)" This reverts commit 4264a67.
codelipenghui
approved these changes
Jun 8, 2021
sijie
approved these changes
Jun 8, 2021
hangc0276
approved these changes
Jun 8, 2021
freeznet
approved these changes
Jun 8, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jun 8, 2021
#10861) This reverts commit 4264a67. ### Motivation The change #8796 has broken the Pulsar Functions running on Kubernetes. The Pulsar Functions Kubernetes runtime generates a secret and mounts it using mode `256`. That means the secret is only able to read by the user. The StatefulSet created by Kubernetes runtime mounts the secrets under the `root` user. Hence only the root user is able to read the secret. This results in any functions submitted will fail to read the authentication information. Because all the Kubernetes resources generated by the Kubernetes runtime are hardcoded. There is no easy way to change the security context for the function statefulsets. Let's revert this change for 2.8.0, until we can address the issues in the Kubernetes runtime. (cherry picked from commit 4f556a2)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
apache#10861) This reverts commit 4264a67. ### Motivation The change apache#8796 has broken the Pulsar Functions running on Kubernetes. The Pulsar Functions Kubernetes runtime generates a secret and mounts it using mode `256`. That means the secret is only able to read by the user. The StatefulSet created by Kubernetes runtime mounts the secrets under the `root` user. Hence only the root user is able to read the secret. This results in any functions submitted will fail to read the authentication information. Because all the Kubernetes resources generated by the Kubernetes runtime are hardcoded. There is no easy way to change the security context for the function statefulsets. Let's revert this change for 2.8.0, until we can address the issues in the Kubernetes runtime.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
apache#10861) This reverts commit 4264a67. ### Motivation The change apache#8796 has broken the Pulsar Functions running on Kubernetes. The Pulsar Functions Kubernetes runtime generates a secret and mounts it using mode `256`. That means the secret is only able to read by the user. The StatefulSet created by Kubernetes runtime mounts the secrets under the `root` user. Hence only the root user is able to read the secret. This results in any functions submitted will fail to read the authentication information. Because all the Kubernetes resources generated by the Kubernetes runtime are hardcoded. There is no easy way to change the security context for the function statefulsets. Let's revert this change for 2.8.0, until we can address the issues in the Kubernetes runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eate and Use pulsar User (nonroot user) (#8796)"
This reverts commit 4264a67.
Motivation
The change #8796 has broken the Pulsar
Functions running on Kubernetes.
The Pulsar Functions Kubernetes runtime generates a secret and mounts it
using mode
256. That means the secret is only able to read by the user.The StatefulSet created by Kubernetes runtime mounts the secrets under the
rootuser. Hence only the root user is able to read the secret. Thisresults in any functions submitted will fail to read the authentication
information.
Because all the Kubernetes resources generated by the Kubernetes runtime
are hardcoded. There is no easy way to change the security context for the
function statefulsets.
Let's revert this change for 2.8.0, until we can address the issues in the Kubernetes runtime.