Make KeyValueSchema an interface visible in the public Schema API #10888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema
eolivelli
added
the
release/blocker
lhotari
reviewed
Jun 10, 2021
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/KeyValueSchema.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Jun 10, 2021
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Jun 10, 2021
sijie
approved these changes
Jun 10, 2021
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 10, 2021
…ache#10888) * Make KeyValueSchema an interface visible in the public Schema API - allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema (cherry picked from commit 18f2f4a)
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 10, 2021
…ache#10888) * Make KeyValueSchema an interface visible in the public Schema API - allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema (cherry picked from commit 18f2f4a)
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 14, 2021
…ache#10888) * Make KeyValueSchema an interface visible in the public Schema API - allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema (cherry picked from commit 18f2f4a) (cherry picked from commit 1ecadd4)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…ache#10888) * Make KeyValueSchema an interface visible in the public Schema API - allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ache#10888) * Make KeyValueSchema an interface visible in the public Schema API - allow users of pulsar-client-api to use KeyValueSchema - move KeyValueSchema implementation to KeyValueSchemaImpl - introduce a new interface KeyValueSchema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying this change
The integration test file TestGenericObjectSink has been changed to use the new API class.
See the comments in #10878