[C++] fix regex namespace to avoid core dump #11179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimula
force-pushed
the
cpp-regex
branch
2 times, most recently
from
dd3a55c to
a53d074
Compare
Contributor
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Jul 2, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Co-authored-by: kimura <takeshki@yahoo-corp.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
remove usages of
std::regex, which causes core dump with some lower versions of GCC.Modifications
replace
std::regexandboost::regexwithPULSAR_REGEX_NAMESPACE::regexwhose value the version of GCC determines.similar PR: #9533
Verifying this change