[Branch-2.7] Fixes function api can not use authdata to check superuser #11418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* Port the fix apache#10364 to the branch 2.7. Sometimes, the superuser is not only needed the client role but also needs some data in the authentication data to check whether the role is the superuser. The changed interface is introduced from apache#8560, it's safe to change it since there is no release for that.' *Modifications* Change the isSuperUser method to accept the authenticationData and pass it to the authentication provider. So authenticatoin prodiver can get the data saved in the authenticationDataSource.
zymap
requested review from
codelipenghui,
jerrypeng,
sijie,
srkukarni and
tuteng
sijie
approved these changes
Jul 22, 2021
codelipenghui
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Port the fix #10364 to branch 2.7.
Sometimes, the superuser is not only needed the client
role but also needs some data in the authentication data
to check whether the role is the superuser.
The changed interface is introduced from #8560,
it's safe to change it since there is no release for that.'
Modifications
Change the isSuperUser method to accept the authenticationData
and pass it to the authentication provider. So authenticatoin prodiver
can get the data saved in the authenticationDataSource.
Verifying this change