Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression#11594
Merged
codelipenghui merged 2 commits intoapache:masterfrom Aug 9, 2021
Conversation
…/nio/ByteBuffer when enabling topic metadata compression Related to apache#11593. This PR is copy the bytes to the DirectBuf to get around the issue apache#11593.
codelipenghui
added
doc-not-needed
codelipenghui
requested review from
315157973,
gaoran10,
hangc0276,
merlimat and
sijie
codelipenghui
added
release/2.8.1
release/blocker
315157973
reviewed
Aug 8, 2021
|
|
||
| byte[] byteArray = managedLedgerInfo.toByteArray(); | ||
| uncompressedByteBuf = Unpooled.directBuffer(byteArray.length); | ||
| uncompressedByteBuf.writeBytes(byteArray); |
Contributor
There was a problem hiding this comment.
Please add some comments to avoid being optimized for wrappers later by other developers
Contributor
There was a problem hiding this comment.
Unpooled.wrappedBuffer will create ByteBuf on heap and the hasMemoryAddress will return false.
Unpooled.directBuffer will create ByteBuf on PooledUnsafeDirectByteBuf, and the hasMemoryAddress will return false.
hangc0276
approved these changes
Aug 8, 2021
Contributor
hangc0276
left a comment
hangc0276
left a comment
There was a problem hiding this comment.
nice catch!
Please add notes to explain the reason to use Unpooled.directBuffer instead of Unpooled.wrappedBuffer
|
|
||
| byte[] byteArray = managedLedgerInfo.toByteArray(); | ||
| uncompressedByteBuf = Unpooled.directBuffer(byteArray.length); | ||
| uncompressedByteBuf.writeBytes(byteArray); |
Contributor
There was a problem hiding this comment.
Unpooled.wrappedBuffer will create ByteBuf on heap and the hasMemoryAddress will return false.
Unpooled.directBuffer will create ByteBuf on PooledUnsafeDirectByteBuf, and the hasMemoryAddress will return false.
eolivelli
requested changes
Aug 8, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Can we ask for another release at airlift?
It looks like they had a bad compatibility issue on the release.
We do are not in a hurry as this feature is for 2.9
Contributor
Author
|
@eolivelli Yes, we can ask for a new airlift release, but the code is already in branch-2.8, we need to find a way to get around first to unblock 2.8.1 release. |
Contributor
Author
|
The created issue airlift/aircompressor#133 for tracking fix from aircompressor |
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
…/nio/ByteBuffer when enabling topic metadata compression (apache#11594) ### Motivation Related to apache#11593. This PR is copying the bytes to the DirectBuf to get around issue apache#11593. The created issue airlift/aircompressor#133 for tracking fix from [aircompressor](https://github.com/airlift/aircompressor) ### Verifying this change Make the `ManagedLedgerCompressionTest` running on JDK8
hangc0276
pushed a commit
that referenced
this pull request
Aug 12, 2021
…/nio/ByteBuffer when enabling topic metadata compression (#11594) ### Motivation Related to #11593. This PR is copying the bytes to the DirectBuf to get around issue #11593. The created issue airlift/aircompressor#133 for tracking fix from [aircompressor](https://github.com/airlift/aircompressor) ### Verifying this change Make the `ManagedLedgerCompressionTest` running on JDK8 (cherry picked from commit 53c7c13)
Contributor
|
AirLift has been released |
hangc0276
added a commit
that referenced
this pull request
Aug 26, 2021
…r upgrade to 0.20 (#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests.
hangc0276
added a commit
that referenced
this pull request
Aug 26, 2021
…r upgrade to 0.20 (#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests. (cherry picked from commit cc1b983)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…/nio/ByteBuffer when enabling topic metadata compression (apache#11594) ### Motivation Related to apache#11593. This PR is copying the bytes to the DirectBuf to get around issue apache#11593. The created issue airlift/aircompressor#133 for tracking fix from [aircompressor](https://github.com/airlift/aircompressor) ### Verifying this change Make the `ManagedLedgerCompressionTest` running on JDK8
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…r upgrade to 0.20 (apache#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so apache#11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and apache#11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert apache#11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression apache#11594, but keep the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #11593. This PR is copying the bytes to the DirectBuf to get around issue #11593.
Verifying this change
Make the
ManagedLedgerCompressionTestrunning on JDK8