Skip to content

Conversation

@sijia-w
Copy link
Contributor

@sijia-w sijia-w commented Aug 12, 2021

Fixes #11291

The links for [Pulsar Java tutorial](https://github.com/streamlio/pulsar-java-tutorial) and relevant content are broken. Is there any recommendations for what we should use instead? Thanks in advance.

@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 12, 2021

@Anonymitaet @jennifer88huang Please review the changes and I look forward to your recommendation for the links. Thanks.

@Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 13, 2021
@Anonymitaet Anonymitaet added this to the 2.9.0 milestone Aug 13, 2021
@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 13, 2021

@Anonymitaet I do not think it would work. It also uses the repo from streamlio
image
I actually only found pulsar-java-tutorial in personal accounts, but I think we'd better find it somewhere official.

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to go through the whole doc and replace streamlio related contents.

@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 13, 2021

@Huanli-Meng Yes all relevant content should be updated, but I haven't found available sources for pulsar-java-tutorial yet. Do you have any suggestions?

@Huanli-Meng
Copy link
Contributor

Huanli-Meng commented Aug 13, 2021

@sijia-w

Maybe you can double check with Penghui whether the Pulsar repo has such a tutorial folder. If not, you can check whether we can link back to the Pulsar website document.

@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 16, 2021

@codelipenghui Any suggestions for a new link for Pulsar-java-tutorial? Many thanks.

@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 18, 2021

@Huanli-Meng A new issue for pulsar-java-tutorial can be found #11699. Shall we close this pr if there is nothing else to modify for now?

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huanli-Meng Huanli-Meng merged commit ca7c70e into apache:master Aug 18, 2021
@sijia-w sijia-w deleted the fix-11291 branch August 18, 2021 11:01
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Remove Pulsar Dashboard contents

3 participants