[testclient] hide option -s and substitute -ss(0) for it

[yuruguo]

Fixes #11827

Motivation

Option --subscriber-name is redundant and easy to cause interference when the size of --subscriptions is equal to 1 but --num-subscriptions is not equal to 1 in command bin/pulsar-perf consume.

Modifications

• Hide option --subscriber-name
• Replace --subscriber-name with --subscriptions first element
• Modify the corresponding doc.

[yuruguo]

PTAL and approve workflows awaiting approval？ @eolivelli @hangc0276 @merlimat

[gaoran10]

LGTM

[yuruguo]

PTAL @eolivelli @codelipenghui

[Anonymitaet]

Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks

[yuruguo]

Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks

This only affects maser and the version that will be released later

[eolivelli]

it looks like we are not handling compatibility.
with this change the 'subscriberName' parameter is ignored.
that is worse than letting the user see an error.

IMHO we should support the old parameter, it is only a matter of handling it as one single value in subscriptions or something like that

[yuruguo]

it looks like we are not handling compatibility.
with this change the 'subscriberName' parameter is ignored.
that is worse than letting the user see an error.

IMHO we should support the old parameter, it is only a matter of handling it as one single value in subscriptions or something like that

So we don’t need to make any changes? If this is the case I will close this PR.

[eolivelli]

I believe that you can "hide" the parameter
but you have to let the users use the old syntax (with -s)

I am not sure if it is worth.
Using "-s" is quite convenient especially when you are running very simple smoke tests.

what about deprecating "-ss" and let "-s" behave like "-ss" ?

[yuruguo]

I believe that you can "hide" the parameter
but you have to let the users use the old syntax (with -s)

I am not sure if it is worth.
Using "-s" is quite convenient especially when you are running very simple smoke tests.

what about deprecating "-ss" and let "-s" behave like "-ss" ?

Thanks for your suggestion, I think perhaps the following is a way to consider:
Keep parameter -s(no default value) and make it work, but its priority is higher than parameter -ss only when -s is not null(that is, the user specifies -s).
related to code1

related to code2

[eolivelli]

Lgtm

@MMirelli you may be interested in this patch