Improved logic for pausing replicated subscription snapshots when no traffic #11922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
codelipenghui,
congbobo184,
hangc0276,
jerrypeng,
massakam,
rdhabalia and
sijie
merlimat
added a commit
that referenced
this pull request
Sep 16, 2021
…traffic (#11922) * Improved logic for pausing replicated subscription snapshots when no traffic * Removed unused import * Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace * Fixed cast that was not available in tests
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…traffic (apache#11922) * Improved logic for pausing replicated subscription snapshots when no traffic * Removed unused import * Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace * Fixed cast that was not available in tests
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 7, 2022
…traffic (apache#11922) * Improved logic for pausing replicated subscription snapshots when no traffic * Removed unused import * Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace * Fixed cast that was not available in tests (cherry picked from commit 28a223c)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #10292, we've added logic to pause the creation of new replicated subscription snapshots when there is no traffic.
Here, I'm changing it to a different approach to avoid a potential issue and to simplify the logic.
Comparing the last message id, we had to use stop taking a snapshot when there are no connected producer, in order to create a "quiet period" and check if the last message id didn't change.
What can happen is that if producers disconnect, we might not create the last snapshot (at least until new producers will get connected).
Modifications
Instead of checking producers and last message id, let's make sure that the last snapshot was initiated after the last "data" message was published. With "data" message here meaning any non-marker message.