[C++] Fixed attempting to connect to multiple IP addresses #11958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
BewareMyPower,
codelipenghui,
hangc0276 and
rdhabalia
hangc0276
approved these changes
Sep 8, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Oct 11, 2021
(cherry picked from commit e4a9f66)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11950
In #11557 there was a fix to advance the DNS resolver result iterator before attempting to reconnect to the subsequent IP results.
The problem was that the 1st increment was not removed, so we were left to always skip the 2nd DNS result.