[Broker] Fix getTopic may hang #11967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
315157973,
codelipenghui,
eolivelli,
hangc0276 and
merlimat
BewareMyPower
added
type/bug
BewareMyPower
approved these changes
Sep 8, 2021
315157973
reviewed
Sep 8, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
merlimat
reviewed
Sep 8, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
Member
Author
|
/pulsarbot run-failure-checks |
Contributor
Demogorgon314
commented
Sep 13, 2021
...ker/src/test/java/org/apache/pulsar/broker/namespace/OwnerShipCacheForCurrentServerTest.java
Show resolved
Hide resolved
eolivelli
reviewed
Sep 13, 2021
...ker/src/test/java/org/apache/pulsar/broker/namespace/OwnerShipCacheForCurrentServerTest.java
Show resolved
Hide resolved
eolivelli
requested changes
Sep 13, 2021
...ker/src/test/java/org/apache/pulsar/broker/namespace/OwnerShipCacheForCurrentServerTest.java
Outdated
Show resolved
Hide resolved
eolivelli
approved these changes
Sep 14, 2021
eolivelli
approved these changes
Sep 14, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
@315157973 can you please take another look ?
Member
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
|
Contributor
|
Rebase onto latest master branch |
Demogorgon314
force-pushed
the
fix-loadOrCreatePersistentTopic-may-cause-uncaught-exception
branch
from
80b77d2 to
36a82f6
Compare
Member
Author
|
/pulsarbot run-failure-checks |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Link PR in KoP: streamnative/kop#718 and [failed test unit](https://github.com/streamnative/kop/pull/718/checks?check_run_id=3541827178#step:5:353) ### Motivation The bug cause by apache#11012, the `loadOrCreatePersistentTopic` has uncaught exception may cause `getTopic` hang. ### Modifications Caught the exception ### Verifying this change The [unit test](apache#11290) added by @kaushik-develop help to isolate and reproduce the issue. ### Documentation - [x] no-need-doc This is a bug fix, no need documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link PR in KoP:
streamnative/kop#718 and failed test unit
Motivation
The bug cause by #11012, the
loadOrCreatePersistentTopichas uncaught exception may causegetTopichang.Modifications
Caught the exception
Verifying this change
The unit test added by @kaushik-develop help to isolate and reproduce the issue.
Documentation
This is a bug fix, no need documentation.