Skip to content

Conversation

@fengtao1998
Copy link
Contributor

@fengtao1998 fengtao1998 commented Sep 9, 2021

Motivation

To improve doc workflow efficiency, we want to introduce Bot to Pulsar community

Modifications

1.Modified pull request template

2.Added YML file for BOT running

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

You can see the details of BOT here(https://docs.google.com/document/d/1bQfZkSu5nG1tNycpmXXtUFn-Z5-h-uqHv6IXsCEySQ8/edit#)

You can try to test docbot in this repo(https://github.com/fengtao1998/cherry_test)

If you need more BOT functions, please comment

Update the document description format to make it more suitable for BOT
Add document description check BOT
@Anonymitaet
Copy link
Member

@timmyyuan @codelipenghui could you please help review? Many thanks!

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 9, 2021
steps:
- uses: actions/checkout@v2

- uses: pr-bot-test/auto-labeling@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is it not allowed in the ASF to use third party GH Actions using branch name references.
Can we copy this code into an ASF repository ? or at least point to a specific SHA (if it is possible)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is it not allowed in the ASF to use third party GH Actions using branch name references.
Can we copy this code into an ASF repository ? or at least point to a specific SHA (if it is possible)

I have fixed the problem of GH action using third-party branches. I changed to point a sha to quote script. Do you think this is OK? Or can you tell me where the ASF repo is? I'll push the script in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the repo
https://github.com/apache/pulsar-test-infra

having it in our repo is better, as private repos may disappear some day

Copy link
Contributor Author

@fengtao1998 fengtao1998 Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have submitted a pullrequest(apache/pulsar-test-infra#21 ) in this repo. When the merge succeeds, I will apply for review again.

Copy link
Contributor Author

@fengtao1998 fengtao1998 Sep 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the repo in this GH Actions.
@eolivelli PTAL, thanks.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@eolivelli eolivelli merged commit d4702ed into apache:master Sep 22, 2021
eolivelli added a commit to eolivelli/pulsar that referenced this pull request Sep 22, 2021
lhotari pushed a commit that referenced this pull request Sep 22, 2021
…12134)

This reverts commit d4702ed.

Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…" (apache#12134)

This reverts commit d4702ed.

Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants