-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add document label check robot #11977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the document description format to make it more suitable for BOT
Add document description check BOT
|
@timmyyuan @codelipenghui could you please help review? Many thanks! |
.github/workflows/ci-documentbot.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: pr-bot-test/auto-labeling@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is it not allowed in the ASF to use third party GH Actions using branch name references.
Can we copy this code into an ASF repository ? or at least point to a specific SHA (if it is possible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this action into https://github.com/apache/pulsar-test-infra ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is it not allowed in the ASF to use third party GH Actions using branch name references.
Can we copy this code into an ASF repository ? or at least point to a specific SHA (if it is possible)
I have fixed the problem of GH action using third-party branches. I changed to point a sha to quote script. Do you think this is OK? Or can you tell me where the ASF repo is? I'll push the script in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the repo
https://github.com/apache/pulsar-test-infra
having it in our repo is better, as private repos may disappear some day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have submitted a pullrequest(apache/pulsar-test-infra#21 ) in this repo. When the merge succeeds, I will apply for review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the repo in this GH Actions.
@eolivelli PTAL, thanks.
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
This reverts commit d4702ed.
…" (apache#12134) This reverts commit d4702ed. Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Motivation
To improve doc workflow efficiency, we want to introduce Bot to Pulsar community
Modifications
1.Modified pull request template
2.Added YML file for BOT running
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)
You can see the details of BOT here(https://docs.google.com/document/d/1bQfZkSu5nG1tNycpmXXtUFn-Z5-h-uqHv6IXsCEySQ8/edit#)
You can try to test docbot in this repo(https://github.com/fengtao1998/cherry_test)
If you need more BOT functions, please comment