Skip to content

Conversation

@thomasleplus
Copy link
Contributor

This line was actually assigning the method argument to itself instead of setting the static field of the same name.

Motivation

Fix a simple mistake.

Modifications

Trivial change.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Sep 18, 2021
@thomasleplus
Copy link
Contributor Author

I am investigating the failing test.

@eolivelli
Copy link
Contributor

eolivelli commented Sep 18, 2021

It is probably a flaky test. Don't bother

Thank you

@eolivelli eolivelli changed the title Fix last exit code storage PulsarAdmin: Fix last exit code storage Sep 18, 2021
@thomasleplus
Copy link
Contributor Author

Hi @codelipenghui, I see that you assigned this PR back to me, does this mean there is something left for me to do?

@eolivelli
Copy link
Contributor

it means that you are the author of the PR, nothing more.
this way it is easier to "count" your contributions, and finally someday invite you as a committer :-)

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@315157973
Copy link
Contributor

/pulsarbot run-failure-checks

@315157973 315157973 closed this Nov 2, 2021
@315157973
Copy link
Contributor

@thomasleplus Sorry, I closed this PR by mistake, could you please open it again?

@thomasleplus
Copy link
Contributor Author

@thomasleplus Sorry, I closed this PR by mistake, could you please open it again?

GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their support team can reopen the request, they are pretty good and reactive in my experience. Otherwise I can create another PR. Let me know what you think is best.

@315157973
Copy link
Contributor

@thomasleplus Sorry, I closed this PR by mistake, could you please open it again?

GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their support team can reopen the request, they are pretty good and reactive in my experience. Otherwise I can create another PR. Let me know what you think is best.

Let's create a new PR, I want to merge it as soon as possible, 2.8.2 is releasing

@thomasleplus
Copy link
Contributor Author

Sure, here you go: #12581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs release/2.8.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants