-
Notifications
You must be signed in to change notification settings - Fork 3.7k
PulsarAdmin: Fix last exit code storage #12082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am investigating the failing test. |
|
It is probably a flaky test. Don't bother Thank you |
|
Hi @codelipenghui, I see that you assigned this PR back to me, does this mean there is something left for me to do? |
|
it means that you are the author of the PR, nothing more. |
|
/pulsarbot run-failure-checks |
|
@thomasleplus Sorry, I closed this PR by mistake, could you please open it again? |
GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their support team can reopen the request, they are pretty good and reactive in my experience. Otherwise I can create another PR. Let me know what you think is best. |
Let's create a new PR, I want to merge it as soon as possible, 2.8.2 is releasing |
|
Sure, here you go: #12581 |
This line was actually assigning the method argument to itself instead of setting the static field of the same name.
Motivation
Fix a simple mistake.
Modifications
Trivial change.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?