Avoid trying to refresh MetadataCaches when we're disconnected from ZK #12120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
BewareMyPower,
codelipenghui,
hangc0276 and
rdhabalia
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Show resolved
Hide resolved
eolivelli
reviewed
Sep 23, 2021
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Show resolved
Hide resolved
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Outdated
Show resolved
Hide resolved
merlimat
added
the
type/enhancement
michaeljmarshall
approved these changes
Sep 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
apache#12120) * Avoid trying to refresh MetadataCaches when we're disconnected from ZK * Address comments
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're using a 5min TTL for entries stored in the metadata cache. After that time a refresh is triggered in background.
This is done to prevent an entry that could have gone out of sync to remain stale forever.
As an enhancement, if we know that we are not connected to metadata service, we should not attempt the refresh because it would certainly fail. Instead, we wait until we're reconnected back.