Skip to content

Conversation

@fengtao1998
Copy link
Contributor

@fengtao1998 fengtao1998 commented Sep 22, 2021

Update the doc BOT configuration about github token

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@fengtao1998 fengtao1998 changed the title [doc] Update thedoc BOT configuration [doc] Update the doc BOT configuration Sep 22, 2021
@fengtao1998 fengtao1998 reopened this Sep 22, 2021
@fengtao1998
Copy link
Contributor Author

@eolivelli PTAL

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think will work.

"A GitHub token created for a PR coming from a fork doesn't have
'admin' or 'write' permission (which is required to add labels)"

added as a comment to:

# A GitHub token created for a PR coming from a fork doesn't have
# 'admin' or 'write' permission (which is required to add labels)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Lari

I am pushing a revert

@eolivelli
Copy link
Contributor

#12134

@fengtao1998
Copy link
Contributor Author

For this document robot, an account with repo management permission is required. In order to save steps, I consider using reference to the existing token to reduce the trouble of creating a new account. But it seems that this is not feasible. Can I get the token of a new account with label permission? Thank you for your reply
@lhotari @eolivelli

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants