[Transaction] Transaction coordinator client connect add response command. #12301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
July 19, 2021 11:05
…mechanism # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java # pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java # pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java # pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java # pulsar-common/src/main/proto/PulsarApi.proto
congbobo184
requested review from
315157973,
codelipenghui,
eolivelli,
gaoran10 and
hangc0276
eolivelli
approved these changes
Oct 8, 2021
| cnx.channel().close(); | ||
| } | ||
| // if broker protocol version < 19, don't send TcClientConnectRequest to broker. | ||
| if (cnx.getRemoteEndpointProtocolVersion() > ProtocolVersion.v18.getValue()) { |
codelipenghui
approved these changes
Oct 8, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…mand. (apache#12301) ## Motivation now apache#11357 has merged, apache#11357 use `SUCCESS` command handle tcClientConnectRequest, This is not conducive to later expansion. So add a individual response for `CommandTcClientConnectRequest` ## implement add command ``` message CommandTcClientConnectResponse { required uint64 request_id = 1; optional ServerError error = 2; optional string message = 3; } ``` In order to ensure that the new client is compatible with the old broker, I update protocol version to 19. ``` v19 = 19; // Add CommandTcClientConnectRequest and CommandTcClientConnectResponse ``` if broker protocol version > 18 we should send TcClientConnectCommand if broker protocol version <= 18 we don't need to send TcClientConnectCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
now #11357 has merged, #11357 use
SUCCESScommand handle tcClientConnectRequest, This is not conducive to later expansion. So add a individual response forCommandTcClientConnectRequestimplement
add command
In order to ensure that the new client is compatible with the old broker, I update protocol version to 19.
if broker protocol version > 18 we should send TcClientConnectCommand
if broker protocol version <= 18 we don't need to send TcClientConnectCommand
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (yes)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)