[C++] Support configuring optional scope field for OAuth2 authentication #12305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
component/c++
doc-not-needed
BewareMyPower
requested review from
aahmed-se,
jiazhai,
merlimat,
tuteng and
zymap
merlimat
approved these changes
Oct 8, 2021
tuteng
reviewed
Oct 9, 2021
BewareMyPower
added
doc-required
tuteng
added
doc-not-needed
BewareMyPower
added
the
doc-required
tuteng
pushed a commit
that referenced
this pull request
Oct 11, 2021
…ion (#12305) It's a C++ client catchup for #11931. - Add a `scope_` field to `ClientCredentialFlow` and load it from `ParamMap` object whose key is `scope`. - Refactor `ClientCredentialFlow` to simplify code and make it testable: - Use only one constructor instead of two overloaded constructors that might look confused - Add a `generateJsonBody` public method for generating JSON body for post fields in `authenticate` so that it can be tested. - Add a `KeyFile` class like what Java client does to load client id and client secret from `ParamMap` or file. - [x] Make sure that the change passes the CI checks. This change added test `AuthPluginTest.testOauth2RequestBody` for the cases that scope exists or doesn't exist. (cherry picked from commit 44dcc04)
codelipenghui
pushed a commit
that referenced
this pull request
Oct 11, 2021
…ion (#12305) It's a C++ client catchup for #11931. - Add a `scope_` field to `ClientCredentialFlow` and load it from `ParamMap` object whose key is `scope`. - Refactor `ClientCredentialFlow` to simplify code and make it testable: - Use only one constructor instead of two overloaded constructors that might look confused - Add a `generateJsonBody` public method for generating JSON body for post fields in `authenticate` so that it can be tested. - Add a `KeyFile` class like what Java client does to load client id and client secret from `ParamMap` or file. - [x] Make sure that the change passes the CI checks. This change added test `AuthPluginTest.testOauth2RequestBody` for the cases that scope exists or doesn't exist. (cherry picked from commit 44dcc04)
Anonymitaet
removed
the
doc-required
Anonymitaet
added
the
type/enhancement
|
@BewareMyPower:Thanks for your contribution. For this PR, do we need to update docs? |
Anonymitaet
added
doc-complete
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ion (apache#12305) ### Motivation It's a C++ client catchup for apache#11931. ### Modifications - Add a `scope_` field to `ClientCredentialFlow` and load it from `ParamMap` object whose key is `scope`. - Refactor `ClientCredentialFlow` to simplify code and make it testable: - Use only one constructor instead of two overloaded constructors that might look confused - Add a `generateJsonBody` public method for generating JSON body for post fields in `authenticate` so that it can be tested. - Add a `KeyFile` class like what Java client does to load client id and client secret from `ParamMap` or file. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added test `AuthPluginTest.testOauth2RequestBody` for the cases that scope exists or doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's a C++ client catchup for #11931.
Modifications
scope_field toClientCredentialFlowand load it fromParamMapobject whose key isscope.ClientCredentialFlowto simplify code and make it testable:generateJsonBodypublic method for generating JSON body for post fields inauthenticateso that it can be tested.KeyFileclass like what Java client does to load client id and client secret fromParamMapor file.Verifying this change
This change added test
AuthPluginTest.testOauth2RequestBodyfor the cases that scope exists or doesn't exist.