[Branch-2-7] Roll back to using Java 8 for docker images #12357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
cckellogg,
codelipenghui,
gaoran10,
hangc0276 and
rdhabalia
codelipenghui
approved these changes
Oct 14, 2021
hangc0276
approved these changes
Oct 14, 2021
yuruguo
approved these changes
Oct 14, 2021
Member
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #12017 the base image for Docker images was changes by cherry-picking a change from 2.8. The reason was that the old image was not working anymore in the docker build, since some of the apt-get repos stopped working.
The side effect was that 2.7 branch was switched to Java 11 runtime in the Docker image, something that we should not do in a patch release.