fix windows test path probleam #12398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
BewareMyPower
added
area/test
doc-not-needed
BewareMyPower
approved these changes
Oct 19, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
* up/master: [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
….2-chapter-4 * website/branch-2.7.2-chapter-3: Update the nesting of forms in the document [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
codelipenghui
pushed a commit
that referenced
this pull request
Oct 21, 2021
### Motivation Make unit test path compatible to windows， make these tests can run on windows ### Modifications Same to #12329 , change `"file://" + tokenFile` to `"file:///" + tokenFile.toString().replace('\\', '/')` Run in windows can't recognize format like `file://C\xxx\yyy\zzz` It should be `file:///C` and the `\` should be `/` (cherry picked from commit 4da4310)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
### Motivation Make unit test path compatible to windows， make these tests can run on windows ### Modifications Same to #12329 , change `"file://" + tokenFile` to `"file:///" + tokenFile.toString().replace('\\', '/')` Run in windows can't recognize format like `file://C\xxx\yyy\zzz` It should be `file:///C` and the `\` should be `/` (cherry picked from commit 4da4310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make unit test path compatible to windows， make these tests can run on windows
Modifications
Same to #12329 , change
"file://" + tokenFileto"file:///" + tokenFile.toString().replace('\\', '/')Run in windows can't recognize format like
file://C\xxx\yyy\zzzIt should be
file:///Cand the\should be/Documentation
unit test optimization