Fix bug that consumer which specify incorrect subscription hangs up w… #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen subscription_auth_mode is Prefix
Contributor
Author
|
@jai1 I have added the tests. |
jai1
approved these changes
Feb 20, 2018
Contributor
jai1
left a comment
jai1
left a comment
There was a problem hiding this comment.
LGTM - once merged can you please backport the fix
merlimat
pushed a commit
that referenced
this pull request
Feb 20, 2018
#1256) * Fix bug that consumer which specify incorrect subscription hangs up when subscription_auth_mode is Prefix * Add test for subscription prefix authorization
Contributor
|
@jai1 Backported into 1.22 |
Contributor
Author
|
Thank you for backporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen subscription_auth_mode is Prefix
Motivation
When
subscription_auth_modeisPrefix, a consumer which use a subscription name that does NOT start with the auth role name hangs up forever without error.cf. #899
Modifications
The cause of this issue is that ServerCnx is not handling the exception that is thrown if the subscription name is incorrect.
I have modified ServerCnx to catch the exception and return an error to the client.
Result
If an incorrect subscription name is specified, subscribing will immediately fail.