Remove unused code in PulsarAdminTool #12603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shoothzj:Thanks for providing doc info! |
codelipenghui
approved these changes
Nov 3, 2021
315157973
approved these changes
Nov 3, 2021
Contributor
|
@codelipenghui @315157973 Please pay attention to this PR(#12581), there are differences between the two, remove or assign |
Member
Author
wow, #12581 is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Remove unused code in PulsarAdminTool
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc