[Java Client] Remove invalid call to Thread.currentThread().interrupt(); #12652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Thread.currentThread().interrupt() shouldn't be called here.
- it must only be called when handling an InterruptedException.
- this looks like a copy-paste bug introduced in
https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183
lhotari
added
type/bug
lhotari
requested review from
315157973,
codelipenghui,
eolivelli and
merlimat
yuruguo
approved these changes
Nov 6, 2021
eolivelli
approved these changes
Nov 6, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Lgtm
That's definitely a bad place to Interupt the current Thread.
Good catch
Jason918
approved these changes
Nov 6, 2021
merlimat
approved these changes
Nov 6, 2021
Contributor
While it's wrong, it shouldn't be too bad :) . The interrupt will just flip the flag so that any blocking call can use that as a way to stop the wait. |
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 7, 2021
* up/master: (55 commits) [broker] remove useless method "PersistentTopic#getPersistentTopic" (apache#12655) [Python Schema] Python schema support custom Avro configurations for Enum type (apache#12642) Allow to configure different implementations for Pulsar functions state store (apache#12646) Remove replicator global test from the quarantine group (apache#12648) [Java Client] Remove invalid call to Thread.currentThread().interrupt(); (apache#12652) k8s runtime: force deletion to avoid hung function worker during connector restart (apache#12504) [Broker] Optimize exception information for schemas (apache#12647) Close Zk database on unit tests (apache#12649) Fix call sync method in an async callback when enabling geo replicator. (apache#12590) [pulsar-broker] Add git branch information for PulsarVersion (apache#12541) PulsarAdmin: Fix last exit code storage (apache#12581) Add @test annotation to test methods (apache#12640) Upgrade debezium to 1.7.1 (apache#12644) [ML] Avoid passing OpAddEntry across a thread boundary in asyncAddEntry (apache#12606) [Functions] Prevent NPE while stopping a non started Pulsar LogAppender (apache#12643) Update io-debezium-source.md (apache#12638) Add missing cmds on pulsar-admin document page (apache#12634) Clean up the metadata of the non-persistent partitioned topics. (apache#12550) modify check waitingForPingResponse with volatile (apache#12615) [pulsar-admin] Check backlog quota policy for namespace (apache#12512) ...
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 7, 2021
* up/master: (55 commits) [broker] remove useless method "PersistentTopic#getPersistentTopic" (apache#12655) [Python Schema] Python schema support custom Avro configurations for Enum type (apache#12642) Allow to configure different implementations for Pulsar functions state store (apache#12646) Remove replicator global test from the quarantine group (apache#12648) [Java Client] Remove invalid call to Thread.currentThread().interrupt(); (apache#12652) k8s runtime: force deletion to avoid hung function worker during connector restart (apache#12504) [Broker] Optimize exception information for schemas (apache#12647) Close Zk database on unit tests (apache#12649) Fix call sync method in an async callback when enabling geo replicator. (apache#12590) [pulsar-broker] Add git branch information for PulsarVersion (apache#12541) PulsarAdmin: Fix last exit code storage (apache#12581) Add @test annotation to test methods (apache#12640) Upgrade debezium to 1.7.1 (apache#12644) [ML] Avoid passing OpAddEntry across a thread boundary in asyncAddEntry (apache#12606) [Functions] Prevent NPE while stopping a non started Pulsar LogAppender (apache#12643) Update io-debezium-source.md (apache#12638) Add missing cmds on pulsar-admin document page (apache#12634) Clean up the metadata of the non-persistent partitioned topics. (apache#12550) modify check waitingForPingResponse with volatile (apache#12615) [pulsar-admin] Check backlog quota policy for namespace (apache#12512) ...
eolivelli
pushed a commit
that referenced
this pull request
Nov 9, 2021
…(); (#12652) - Thread.currentThread().interrupt() shouldn't be called here. - it must only be called when handling an InterruptedException. - this looks like a copy-paste bug introduced in https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183 (cherry picked from commit b5f78f8)
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
…(); (#12652) - Thread.currentThread().interrupt() shouldn't be called here. - it must only be called when handling an InterruptedException. - this looks like a copy-paste bug introduced in https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183 (cherry picked from commit b5f78f8)
codelipenghui
added
release/2.8.2
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…(); (apache#12652) - Thread.currentThread().interrupt() shouldn't be called here. - it must only be called when handling an InterruptedException. - this looks like a copy-paste bug introduced in https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183
michaeljmarshall
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 8, 2021
…(); (apache#12652) - Thread.currentThread().interrupt() shouldn't be called here. - it must only be called when handling an InterruptedException. - this looks like a copy-paste bug introduced in https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183 (cherry picked from commit b5f78f8)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
…(); (#12652) - Thread.currentThread().interrupt() shouldn't be called here. - it must only be called when handling an InterruptedException. - this looks like a copy-paste bug introduced in https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183 (cherry picked from commit b5f78f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Thread.currentThread().interrupt()shouldn't be called when handling aPulsarClientException.InterruptedException.https://github.com/apache/pulsar/pull/731/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1183
Modifications
Thread.currentThread().interrupt()