Remove catching NamingException.
#12725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 10, 2021
RobertIndie
approved these changes
Nov 10, 2021
RobertIndie
reviewed
Nov 11, 2021
Member
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
I think we can remove the NamingException thrown in the constructor of the SystemTopic and PersistentTopic.
Contributor
Author
Yes, right. thanks. |
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit 6ab7401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #12590, we wrap
NamingExceptioninto CompletableFuture in AbstractReplicator#validatePartitionedTopicAsync.So in BrokerService#createNonPersistentTopic, it will never throw
NamingException.Modifications
NamingException.Documentation
no-need-doc