[Broker] Synchronize updates to the inactiveProducers map in MessageD… #12820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@merlimat and @congbobo184 - PTAL. Based on #12493 (comment), it looks like we prefer synchronization on the class as opposed to using a concurrent hash map. Let me know if my assumption here is correct, thanks. |
Contributor
|
@merlimat I can include this patch in 2.9.0. |
merlimat
approved these changes
Nov 15, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
lhotari
added
type/bug
Member
|
depends on #12493 |
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 10, 2021
…eduplication (apache#12820) (cherry picked from commit 9994614) (cherry picked from commit e12bcc2)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eduplication
Motivation
In #12493, we introduced potentially concurrent updates to the
inactiveProducersmap without any synchronization.Modifications
inactiveProducersmap using proper synchronization.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
No breaking changes.
Documentation
no-need-doc