PIP-45: Converted BookieRackAffinityMapping to use MetadataStore #12841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
BewareMyPower,
codelipenghui,
eolivelli,
hangc0276 and
rdhabalia
eolivelli
approved these changes
Dec 1, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I hope we have good coverage about this feature.
It is very important for users and a bug in this will lead to serious problems
| /** | ||
| * It provides the mapping of bookies to its rack from zookeeper. | ||
| */ | ||
| public class ZkBookieRackAffinityMapping extends AbstractDNSToSwitchMapping |
Contributor
There was a problem hiding this comment.
We should keep the old class, otherwise, we will break the user's cluster after upgrading to the new Pulsar version.
This one is used in bookkeeper.conf, reppDnsResolverClass=org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping.
Contributor
Author
There was a problem hiding this comment.
I don't find it in the config files, but yes, it's a good idea to retain the name. I'll add it back as an empty class extending the new one.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…che#12841) * PIP-45: Converted BookieRackAffinityMapping to use MetadataStore * WIP * Only initialize bookieMappingCache if we have an isolation group * Added back compatibility class wrappers
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The BookieRackAffinityMapping is based on reading the (bookie->rack) mapping from a z-node. Therefore we're injecting the ZK client in the RackAffinity plugin.
Instead, we are going to inject the instance of
MetadataStorein the properties, so that we're not depending on the ZK implementation.