[Issue 12883] Fix flaky test in PersistentStreamingDispatcherBlockConsumerTest #12943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lhotari Can you help review this fix. It's actually verified in several of my other PRs. |
lhotari
approved these changes
Nov 23, 2021
hangc0276
approved these changes
Nov 23, 2021
hezhangjian
approved these changes
Nov 23, 2021
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
…stBlockBrokerDispatching (apache#12943)
Merged
2 tasks
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…stBlockBrokerDispatching (apache#12943)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…stBlockBrokerDispatching (apache#12943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12883
Motivation
A quick fix for flaky test in PersistentStreamingDispatcherBlockConsumerTest.
The reason of time increase is most likely the warning logs in metadata store.
Modifications
Increase timeout from 10s to 60s.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docFix flaky.