[Docker] Enable filesystem permission updates in derivative docker im… #12956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@lhotari - PTAL |
Contributor
|
@timmyyuan please help to review this PR when you have time, thanks. |
Contributor
|
LGTM |
merlimat
approved these changes
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ages
Master Issue: #11269 and #8242
Motivation
@roelrymenants points out in #8242:
I realized today that because we removed the standalone docker image in #11657, we can now removed the
VOLUMEcommand in the dockerfile and make it easier for end users to extend the pulsar docker image. I describe moving theVOLUMEcommand here #8796 (comment).I think I should be able to make the pulsar docker images OpenShift compliant and non-root by default in early December. Until then, it is still valuable to update docker image to make it easier for end users to extend the image.
Modifications
VOLUMEdirective from thepulsardockerfile.Verifying this change
Now that we removed the standalone docker image, there is no need for the
VOLUMEcommand.Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
no-need-docThis is a minor feature that does not need documentation. I'll provide docs when I update the pulsar docker image to be non-root/OpenShift compliant.